Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish BMC Status even on failure from PEI #225

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

cfernald
Copy link
Contributor

@cfernald cfernald commented Mar 28, 2024

Description

Removes the quick returns that cause the BMC Status HOB to not be created during failures in PEI. This allows DXE and MM to check the original init attempt status and fail out quickly if needed.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

N/A

Integration Instructions

N/A

@cfernald cfernald requested a review from apop5 March 28, 2024 16:47
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.82%. Comparing base (15a5e96) to head (9d09116).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   25.80%   25.82%   +0.02%     
==========================================
  Files          44       44              
  Lines        3248     3245       -3     
  Branches      271      271              
==========================================
  Hits          838      838              
+ Misses       2404     2401       -3     
  Partials        6        6              
Flag Coverage Δ
IpmiFeaturePkg 25.82% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfernald cfernald merged commit 1d3e09e into microsoft:main Mar 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants