Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Digitizer touch input usages as pointer buttons #496

Merged

Conversation

joschock
Copy link
Contributor

@joschock joschock commented Jun 5, 2024

Description

This PR adds support for Digitizer switch usages (HID Usage Page 0xD, usages 0x42 through 0x46) as buttons in the AbsolutePointer implementation.

See https://usb.org/document-library/hid-usage-tables-15 for usage tables.

  • Impacts functionality?
    • Add support for Digitizer switch usages as buttons in the pointer interface.
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Functionally verified with a touch panel implementation that exposes these HID usages.

Integration Instructions

No special integration required.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.86%. Comparing base (2d6746b) to head (9394d7d).

Additional details and impacted files
@@               Coverage Diff               @@
##           release/202311     #496   +/-   ##
===============================================
  Coverage           10.86%   10.86%           
===============================================
  Files                 142      142           
  Lines               22381    22381           
  Branches             1808     1808           
===============================================
  Hits                 2432     2432           
  Misses              19917    19917           
  Partials               32       32           
Flag Coverage Δ
HidPkg 2.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makubacki makubacki merged commit f7327e7 into microsoft:release/202311 Jun 17, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants