Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdvLoggerPkg: AssertLib update PI Status Code to match PI spec #530

Merged

Conversation

VivianNK
Copy link
Contributor

@VivianNK VivianNK commented Jul 23, 2024

Description

Remove usage of custom Pi Status code to use one defined in spec, EFI_SW_EC_ILLEGAL_SOFTWARE_STATE.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

CI

Integration Instructions

For any telemetry report that used EFI_SW_EC_RELEASE_ASSERT, replace with EFI_SW_EC_ILLEGAL_SOFTWARE_STATE

Remove usage of custom Pi Status code to use one defined in spec,
EFI_SW_EC_ILLEGAL_SOFTWARE_STATE.
@VivianNK VivianNK requested a review from apop5 July 23, 2024 22:51
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Jul 23, 2024
@VivianNK VivianNK requested review from kuqin12 and os-d July 23, 2024 22:51
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.04%. Comparing base (69e9464) to head (31fe8a3).

Additional details and impacted files
@@               Coverage Diff               @@
##           release/202311     #530   +/-   ##
===============================================
  Coverage           11.04%   11.04%           
===============================================
  Files                 144      144           
  Lines               22019    22019           
  Branches             2356     2356           
===============================================
  Hits                 2432     2432           
  Misses              19555    19555           
  Partials               32       32           
Flag Coverage Δ
AdvLoggerPkg 3.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VivianNK VivianNK merged commit 013d135 into microsoft:release/202311 Jul 23, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants