Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-Pick] Fix a debug string format specifier. #545

Conversation

apop5
Copy link
Contributor

@apop5 apop5 commented Aug 7, 2024

Description

Fix an issue where the wrong format specifier was used for an ASCII string.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Observed that ID_NOT_FOUND string was properly formatted.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Aug 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 11.01%. Comparing base (87399cb) to head (73302f5).

Files Patch % Lines
...eIdSupportLibSmbios/MfciDeviceIdSupportLibSmbios.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release/202311     #545   +/-   ##
===============================================
  Coverage           11.01%   11.01%           
===============================================
  Files                 144      144           
  Lines               22079    22079           
  Branches             2356     2356           
===============================================
  Hits                 2432     2432           
  Misses              19615    19615           
  Partials               32       32           
Flag Coverage Δ
MfciPkg 39.37% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apop5 apop5 requested review from makubacki and os-d August 7, 2024 22:31
@apop5 apop5 requested a review from kuqin12 August 7, 2024 23:20
@makubacki makubacki enabled auto-merge (rebase) August 8, 2024 22:51
## Description

Fix an issue where the wrong format specifier was used for an ASCII
string.

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

Observed that ID_NOT_FOUND string was properly formatted.

## Integration Instructions

N/A
@makubacki makubacki force-pushed the personal/apop5/cherrypickformatstring branch from 73302f5 to 1d6f7f5 Compare August 8, 2024 22:52
@makubacki makubacki merged commit 64cbc06 into microsoft:release/202311 Aug 8, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants