Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DxeCore AdvancedLogger GoogleTest #569

Conversation

VivianNK
Copy link
Contributor

@VivianNK VivianNK commented Aug 29, 2024

Description

Add GoogleTest for AdvancedLogger DxeCore Lib

Add mock for AdvancedLoggerHdwPortLib

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

CI

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Aug 29, 2024
@VivianNK VivianNK force-pushed the personal/vnowkakeane/advloggertestdxecore branch from 0ae130b to d5acff2 Compare September 9, 2024 21:19
@VivianNK VivianNK force-pushed the personal/vnowkakeane/advloggertestdxecore branch from d5acff2 to 63298d2 Compare September 9, 2024 21:22
@VivianNK VivianNK marked this pull request as ready for review September 9, 2024 21:32
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.21%. Comparing base (93d7793) to head (6e164d5).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/202405     #569      +/-   ##
==================================================
+ Coverage           11.05%   11.21%   +0.15%     
==================================================
  Files                 145      145              
  Lines               22200    22057     -143     
  Branches             2377     2450      +73     
==================================================
+ Hits                 2455     2473      +18     
+ Misses              19711    19550     -161     
  Partials               34       34              
Flag Coverage Δ
AdvLoggerPkg 5.01% <ø> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VivianNK VivianNK force-pushed the personal/vnowkakeane/advloggertestdxecore branch from 63298d2 to f2e99de Compare September 9, 2024 22:08
@VivianNK VivianNK changed the title (WIP) Add DxeCore AdvancedLogger GoogleTest Add DxeCore AdvancedLogger GoogleTest Sep 9, 2024
@VivianNK VivianNK requested a review from apop5 September 9, 2024 22:09
@github-actions github-actions bot added the impact:testing Affects testing label Sep 9, 2024
Use null libraries where possible.
@VivianNK VivianNK force-pushed the personal/vnowkakeane/advloggertestdxecore branch from f2e99de to fd8fbdb Compare September 9, 2024 22:19
@VivianNK VivianNK force-pushed the personal/vnowkakeane/advloggertestdxecore branch from b637bf9 to 6e164d5 Compare September 9, 2024 23:50
@VivianNK VivianNK requested review from os-d and kuqin12 September 10, 2024 00:25
@VivianNK VivianNK merged commit ad28333 into microsoft:release/202405 Sep 11, 2024
30 checks passed
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Sep 25, 2024
Introduces 9 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_plus/commit/bde9c52c420dc4fc075197ae5406cfb4ecc3f3c4">bde9c5</a> AdvLoggerPkg: Exit from write call if signature mismatch (<a href="https://github.com/microsoft/mu_plus/pull/565">#565</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/f56280b7280ccdbb3877f53a3fd348ad7937f4eb">f56280</a> [CHERRY-PICK] Removed All References to PcdAdvancedLoggerPeiInRam (<a href="https://github.com/microsoft/mu_plus/pull/540">#540</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/7c981ae9d492ba9403b65777a4d46174743bea98">7c981a</a> [CHERRY-PICK] Removed reference to PcdAdvancedHdwLoggerDisable in the README (<a href="https://github.com/microsoft/mu_plus/pull/541">#541</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/0f790244e3273db5eae465ae49cbf07468047b52">0f7902</a> pip: bump edk2-pytool-extensions from 0.27.11 to 0.27.12 (<a href="https://github.com/microsoft/mu_plus/pull/571">#571</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/bedfce0da5047d2f27ff302b869fb2ad6d23ec23">bedfce</a> Add MockDeviceBootManagerLib (<a href="https://github.com/microsoft/mu_plus/pull/572">#572</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/93d7793bdd1c88cf8f6747d91d8d0abe2ab9c76e">93d779</a> AdvLoggerPkg: Add GoogleTest for AdvancedLoggerPeiLib (<a href="https://github.com/microsoft/mu_plus/pull/555">#555</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/ad283339db8ac5610f3d1e8f98a2d3b5fd806c1c">ad2833</a> Add DxeCore AdvancedLogger GoogleTest (<a href="https://github.com/microsoft/mu_plus/pull/569">#569</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/f14beb145ac49ddb9a570f6788fff5e7da4f4aad">f14beb</a> pip: bump regex from 2024.7.24 to 2024.9.11 (<a href="https://github.com/microsoft/mu_plus/pull/579">#579</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/5fb0d0462731513e3a28d5c0be1932a765dfe03d">5fb0d0</a> pip: bump edk2-pytool-library from 0.21.10 to 0.21.11 (<a href="https://github.com/microsoft/mu_plus/pull/578">#578</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact impact:testing Affects testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants