MfciPkg: Correct Mfci script for switchover to using edk2toollib Variable service #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #597 |
github-actions
bot
added
language:python
kuqin12
approved these changes
Oct 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #598 +/- ##
===========================================
Coverage 11.40% 11.40%
===========================================
Files 145 145
Lines 21915 21915
Branches 2546 2546
===========================================
Hits 2499 2499
Misses 19382 19382
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Javagedes
approved these changes
Oct 16, 2024
apop5
added a commit
to apop5/mu_plus
that referenced
this pull request
Oct 16, 2024
…able service (microsoft#598) ## Description When switching over to using edk2toollib's UefiVariable, SetVariable was not updated to only expect a single return value. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on a system verifying the python error no longer occurs. ## Integration Instructions N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When switching over to using edk2toollib's UefiVariable, SetVariable was not updated to only expect a single return value.
How This Was Tested
Tested on a system verifying the python error no longer occurs.
Integration Instructions
N/A