Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust Dependency: Bump boot_services from v1.2.0 to v1.2.1 #608

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 11, 2024

Bumps boot_services from v1.2.0 to v1.2.1.

Release notes

Sourced from boot_services's releases.

v1.2.1

What's Changed

With the current structure of the guid! macro, the uuid crate must be added to the dependencies of any crate that uses the macro and the macro itself must be in scope. This provides poor ergonomics for anyone using the macro and the error for not having the uuid crate in scope is not the most clear.

error: cannot find macro `uuid` in this scope
   --> my_component\src\component.rs:170:9
    |
170 |         mu_rust_helpers::guid::guid!("4297bd81-1d1d-49aa-b138-7b54e5807264")
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `uuid` is in scope, but it is a crate, not a macro
    = note: this error originates in the macro `mu_rust_helpers::guid::guid` (in Nightly builds, run with -Z macro-backtrace for more info)

This commit updates the usage of the uuid macro, so that the macro does not require the uuid macro to be in scope (or the uuid crate to be a dependency at all). This is done by specifying that the uuid macro comes from the interior crate (using $crate). This does, however, re-export the uuid! macro, as it must be public for it to be used in other crates.

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Verified the macro can now be used without the need of having the uuid crate as a dependency, or the uuid::uuid! macro in scope in the file.

Integration Instructions

Consumers can remove the uuid crate if not used for any other purposes.

  </blockquote>
  <hr>
</details>

... (truncated)

Commits
  • d44a8b9 guid: guid! macro ergonomics improvement (#37)
  • c958ba7 Repo File Sync: Refactor regex-pull-requests.yml (#36)
  • 12b72d2 Repo File Sync: synced file(s) with microsoft/mu_devops (#34)
  • See full diff in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [boot_services](https://github.com/microsoft/mu_rust_helpers) from v1.2.0 to v1.2.1.
- [Release notes](https://github.com/microsoft/mu_rust_helpers/releases)
- [Commits](microsoft/mu_rust_helpers@v1.2.0...d44a8b9)

---
updated-dependencies:
- dependency-name: boot_services
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added type:dependabot Created by dependabot type:dependencies Pull requests that update a dependency file labels Nov 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.40%. Comparing base (77efeec) to head (81ea873).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405     #608   +/-   ##
===========================================
  Coverage       11.40%   11.40%           
===========================================
  Files             145      145           
  Lines           21915    21915           
  Branches         2546     2546           
===========================================
  Hits             2499     2499           
  Misses          19382    19382           
  Partials           34       34           
Flag Coverage Δ
AdvLoggerPkg 6.05% <ø> (ø)
HidPkg 2.80% <ø> (ø)
MfciPkg 39.37% <ø> (ø)
MsCorePkg 1.39% <ø> (ø)
MsWheaPkg 7.13% <ø> (ø)
XmlSupportPkg 27.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apop5 apop5 merged commit c84ed2d into dev/202405 Nov 12, 2024
28 checks passed
@apop5 apop5 deleted the dependabot/cargo/boot_services-v1.2.1 branch November 12, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:dependabot Created by dependabot type:dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants