Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event handling bug with touch and keyboard input #620

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

wenbhou
Copy link
Contributor

@wenbhou wenbhou commented Jan 21, 2025

Description

Fixes #621

Fix the bug in event handling that occurs when alternating between touch and keyboard inputs, ensuring seamless interaction.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Tested on Surface Laptop and Surface Pro. Booted to UEFI front page and alternated between Touchpad and Keyboard for operation. The interaction was seamless.

Integration Instructions

N/A

@makubacki makubacki added the type:bug Something isn't working label Jan 21, 2025
@makubacki makubacki requested a review from kuqin12 January 21, 2025 15:55
@apop5
Copy link
Contributor

apop5 commented Jan 21, 2025

Should this go into Dev and then get backported into release?

@makubacki
Copy link
Member

Should this go into Dev and then get backported into release?

Yes, I missed the target branch. I'll see if I can rebase Wenbo's PR branch to reduce the work he needs to do.

Wenbo Hou added 2 commits January 21, 2025 13:20
Fix the bug in event handling that occurs when alternating between touch and keyboard inputs, ensuring seamless interaction.
@makubacki makubacki force-pushed the personal/wenbhou/fix_formdisplay branch from 132b3ff to 7ab78cc Compare January 21, 2025 18:20
@makubacki makubacki changed the base branch from release/202405 to dev/202405 January 21, 2025 18:20
@github-actions github-actions bot added the type:backport Backport changes in a dev branch PR to its release branch. label Jan 21, 2025
@makubacki
Copy link
Member

Yes, I missed the target branch. I'll see if I can rebase Wenbo's PR branch to reduce the work he needs to do.

Rebased to dev/202405, changed target branch, added backport label.

@makubacki makubacki enabled auto-merge (squash) January 21, 2025 19:05
@apop5 apop5 disabled auto-merge January 21, 2025 20:14
@apop5 apop5 merged commit f3e3c50 into microsoft:dev/202405 Jan 21, 2025
19 checks passed
ProjectMuBot pushed a commit that referenced this pull request Jan 21, 2025
## Description

Fixes #621 

Fix the bug in event handling that occurs when alternating between touch
and keyboard inputs, ensuring seamless interaction.

- [x] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

## How This Was Tested

Tested on Surface Laptop and Surface Pro. Booted to UEFI front page and
alternated between Touchpad and Keyboard for operation. The interaction
was seamless.

## Integration Instructions

N/A

---------

Co-authored-by: Wenbo Hou <wenbhou@microsoft.com>
makubacki pushed a commit to makubacki/mu_plus that referenced this pull request Jan 22, 2025
## Description

Fixes microsoft#621 

Fix the bug in event handling that occurs when alternating between touch
and keyboard inputs, ensuring seamless interaction.

- [x] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

## How This Was Tested

Tested on Surface Laptop and Surface Pro. Booted to UEFI front page and
alternated between Touchpad and Keyboard for operation. The interaction
was seamless.

## Integration Instructions

N/A

---------

Co-authored-by: Wenbo Hou <wenbhou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:backport Backport changes in a dev branch PR to its release branch. type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Seamless interaction issue on front page with alternating touch and keyboard inputs
4 participants