Skip to content

Commit

Permalink
Remove TempPreUefiEventLogLib since Tcg2PreUefiEventLogLibNull is ava…
Browse files Browse the repository at this point in the history
…ilable (#236)

## Description

The TempPreUefiEventLogLib is an instance of the Tcg2PreUefiEventLogLib,
but it contains an assert for when the library instance is used.

Tcg2PreUefiEventLogNull is now available. TempPreUefiEventLogLib is no
longer necessary to allow builds to complete.

Remove the TempPreUefiEventLogLib instance of TempPreUefiEventLogLib.

- [X] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [x] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

- CI 
- Local build of platform with included change. 

## Integration Instructions

Dsc files that made use of TempPreUefiEventLogLib need to update to
point to the Tcg2PreUefiEventLogLibNull library instance.
  • Loading branch information
apop5 authored and makubacki committed Feb 2, 2024
1 parent c252952 commit dd19f6a
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 58 deletions.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion SecurityPkg/SecurityPkg.dsc
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,6 @@
SecurityPkg/Library/PlatformSecureLibNull/PlatformSecureLibNull.inf
SecurityPkg/Library/Tcg2PpVendorLibNull/Tcg2PpVendorLibNull.inf
SecurityPkg/Library/TcgPpVendorLibNull/TcgPpVendorLibNull.inf
SecurityPkg/Library/TempPreUefiEventLogLib/TempPreUefiEventLogLib.inf
SecurityPkg/Library/Tpm2DebugLib/Tpm2DebugLibNull.inf
SecurityPkg/Library/Tcg2PhysicalPresencePromptLib/Tcg2PhysicalPresencePromptLibConsole.inf
SecurityPkg/Library/Tcg2PreUefiEventLogLibNull/Tcg2PreUefiEventLogLibNull.inf
Expand Down

0 comments on commit dd19f6a

Please sign in to comment.