Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Fix assert.ifError() usage in test #233

Merged
merged 4 commits into from
May 19, 2018

Conversation

fs-eire
Copy link
Contributor

@fs-eire fs-eire commented May 4, 2018

Node 10.x updated the function assert.ifError() so the old usage becomes no longer valid.

8.x: Throws value if value is truthy.
10.x: Throws value if value is not undefined or null. This is useful when testing the error argument in callbacks.

@fs-eire fs-eire closed this May 15, 2018
@fs-eire fs-eire deleted the fix-assert-usage branch May 15, 2018 23:31
@fs-eire fs-eire restored the fix-assert-usage branch May 15, 2018 23:31
@fs-eire fs-eire reopened this May 15, 2018
@fs-eire fs-eire merged commit 833b384 into microsoft:master May 19, 2018
@fs-eire fs-eire deleted the fix-assert-usage branch May 19, 2018 00:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants