This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Change receive_customized_trial_result API
#1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicm-ms
approved these changes
Sep 9, 2019
xuehui1991
reviewed
Sep 9, 2019
src/sdk/pynni/nni/tuner.py
Outdated
| parameter_id: int | ||
| parameters: object created by 'generate_parameters()' | ||
| reward: object reported by trial | ||
| """ | ||
| # TODO: kwargs doc? |
There was a problem hiding this comment.
I'll add the doc later this week.
There was a problem hiding this comment.
But it should not appear in our repo.... keep it in your own branch?
xuehui1991
approved these changes
Sep 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
receive_customized_trial_resultAPI to make customized trials not that special.Tuners will not receive results of customized trials by default.
They can call
self.accept_customized_trials()if they support customizing hyper-parameters. After whichreceive_trial_resultwill receive results from customized trials as well as algorithm-generated trials.NODE: This change is somewhat not backward compatible.
Old tuners are still functional, but they will not receive results from customized trials anymore.