Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix bugs in Make pip-install action #19

Merged
merged 5 commits into from
Sep 10, 2018
Merged

Fix bugs in Make pip-install action #19

merged 5 commits into from
Sep 10, 2018

Conversation

yds05
Copy link
Contributor

@yds05 yds05 commented Sep 10, 2018

Issue:

  1. If use already installed an older node(<10.8), pip install will failed because yarn build will pick the older version node.
  2. pip-install action doesn't create examples folder under $HOME.

Copy link
Contributor

@Crysple Crysple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixs and it seems unnecessary to export yarn cuz the $(YARN) defined at the beginning of Makefile has explicitly to specify the 'yarn'. Otherwise this variable can be deleted and just 'yarn' is used

@yds05 yds05 merged commit 19f8976 into microsoft:master Sep 10, 2018
SparkSnail added a commit that referenced this pull request Oct 11, 2018
suiguoxin pushed a commit that referenced this pull request Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants