This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Support more search space and maxDuration format #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuehui1991
approved these changes
Oct 10, 2018
chicm-ms
reviewed
Oct 10, 2018
| @@ -88,6 +88,20 @@ class Sessionpro extends React.Component<{}, SessionState> { | |||
| }; | |||
| } | |||
|
|
|||
| convertTime = (num: number) => { | |||
| let hour = Math.floor(num / 3600 % 24); | |||
There was a problem hiding this comment.
why mod 24 here? it seems there is no day unit here.
chicm-ms
reviewed
Oct 10, 2018
| } else { | ||
| return result = hour + 'h ' + min + 'min'; | ||
| } | ||
| } |
There was a problem hiding this comment.
This function can be simplified as following:
const hour = Math.floor(num / 3600);
const min = Math.floor(num / 60 % 60);
return hour > 0 ? `${hour} h ${min} min` : `${min} min`
There was a problem hiding this comment.
Thanks very much.
chicm-ms
approved these changes
Oct 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support more search space;
change maxDuration and still running style.