This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Refactor: remote machine isolate OS commands phase 1 #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
April 21, 2020 17:22
fix gpu_metrics_collector to support pyenv fix NASUI failure on dev-install-node-modules add .gitignore links for dev-install
squirrelsc
changed the title
|
It contains changes of #2370 |
QuanluZhang
reviewed
Apr 26, 2020
QuanluZhang
reviewed
Apr 26, 2020
src/nni_manager/training_service/remote_machine/remoteMachineTrainingService.ts
Outdated
Show resolved
Hide resolved
QuanluZhang
reviewed
Apr 26, 2020
src/nni_manager/training_service/remote_machine/remoteMachineTrainingService.ts
Show resolved
Hide resolved
QuanluZhang
reviewed
Apr 28, 2020
QuanluZhang
approved these changes
Apr 29, 2020
liuzhe-lz
reviewed
Apr 29, 2020
src/nni_manager/training_service/remote_machine/extends/linuxCommands.ts
Show resolved
Hide resolved
liuzhe-lz
reviewed
Apr 29, 2020
src/nni_manager/training_service/remote_machine/extends/linuxCommands.ts
Show resolved
Hide resolved
liuzhe-lz
reviewed
Apr 29, 2020
src/nni_manager/training_service/remote_machine/remoteMachineTrainingService.ts
Outdated
Show resolved
Hide resolved
liuzhe-lz
approved these changes
Apr 29, 2020
SparkSnail
reviewed
Apr 29, 2020
SparkSnail
reviewed
Apr 29, 2020
src/nni_manager/training_service/remote_machine/remoteMachineData.ts
Outdated
Show resolved
Hide resolved
SparkSnail
reviewed
Apr 29, 2020
src/nni_manager/training_service/remote_machine/remoteMachineData.ts
Outdated
Show resolved
Hide resolved
SparkSnail
reviewed
Apr 29, 2020
src/nni_manager/training_service/remote_machine/remoteMachineData.ts
Outdated
Show resolved
Hide resolved
SparkSnail
reviewed
Apr 29, 2020
src/nni_manager/training_service/remote_machine/remoteMachineData.ts
Outdated
Show resolved
Hide resolved
2. rename ssh names in other files.
SparkSnail
approved these changes
Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support Windows node in remote mode, this PR adds a layer of commands (osCommands) to deal difference between Windows and Unix-like OS. To share code, ShellExecutor is added to enrich original SshClient class.
I will implement windows version commands in next phase.
This pattern can be expanded to Local or other platform in future, so I moved related code to common folder for sharing.