Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Support dev install on windows #2416

Merged
merged 2 commits into from
May 18, 2020

Conversation

squirrelsc
Copy link
Member

  1. Add scripts in install.ps1 to support install as devlopment.
  2. Add nasui uninstall scripts in uninstall.ps1.
  3. Use rmdir more, as it works with symbolic links better.
  4. Simplify development document, and include this change in it.

Remove-Item $NNI_YARN_FOLDER -Recurse -Force
Remove-Item $NNI_NODE_FOLDER -Recurse -Force
# clean up
cmd /c rmdir /s /q "build"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the drawback of Remove-Item?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove-item doesn't work for symbol links. If use powershell to remove a symbol link, it needs to call like (Get-Item xxx).Delete(). But the Delete() doesn't work for non-empty physical folder.

@SparkSnail SparkSnail merged commit b3a085d into microsoft:master May 18, 2020
@squirrelsc squirrelsc deleted the dev-windows-install branch May 21, 2020 05:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants