This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Fix storage logic #2488
Merged
Fix storage logic #2488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
suggested changes
May 25, 2020
| @@ -31,6 +31,6 @@ fi`; | |||
|
|
|||
| export const PAI_K8S_TRIAL_COMMAND_FORMAT: string = | |||
| `export NNI_PLATFORM=pai NNI_SYS_DIR={0} NNI_OUTPUT_DIR={1} NNI_TRIAL_JOB_ID={2} NNI_EXP_ID={3} NNI_TRIAL_SEQ_ID={4} MULTI_PHASE={5} \ | |||
| && NNI_CODE_DIR={6} && cp -r $NNI_CODE_DIR/. $NNI_SYS_DIR && cd $NNI_SYS_DIR && sh install_nni.sh \ | |||
| && python3 -m nni_trial_tool.trial_keeper --trial_command '{7}' --nnimanager_ip '{8}' --nnimanager_port '{9}' \ | |||
| && NNI_CODE_DIR={6} && mkdir -p $NNI_SYS_DIR/code && cp -r $NNI_CODE_DIR/. $NNI_SYS_DIR/code && sh $NNI_SYS_DIR/install_nni.sh \ | |||
There was a problem hiding this comment.
If to avoid conflict, we can rename run.sh to nni_run.sh to avoid it.
There was a problem hiding this comment.
As discussed with @QuanluZhang , we use a code folder to store users' code files. In this way, NNI will not destroy users' folder structure.
There was a problem hiding this comment.
How about parameter file? It needs to manual run and verify it at least on remote, and pai.
There was a problem hiding this comment.
never mind, I had a check. It looks good, if test cases doesn't timeout.
src/nni_manager/training_service/remote_machine/extends/linuxCommands.ts
Show resolved
Hide resolved
squirrelsc
approved these changes
May 25, 2020
squirrelsc
approved these changes
May 25, 2020
| @@ -31,6 +31,6 @@ fi`; | |||
|
|
|||
| export const PAI_K8S_TRIAL_COMMAND_FORMAT: string = | |||
| `export NNI_PLATFORM=pai NNI_SYS_DIR={0} NNI_OUTPUT_DIR={1} NNI_TRIAL_JOB_ID={2} NNI_EXP_ID={3} NNI_TRIAL_SEQ_ID={4} MULTI_PHASE={5} \ | |||
| && NNI_CODE_DIR={6} && cp -r $NNI_CODE_DIR/. $NNI_SYS_DIR && cd $NNI_SYS_DIR && sh install_nni.sh \ | |||
| && python3 -m nni_trial_tool.trial_keeper --trial_command '{7}' --nnimanager_ip '{8}' --nnimanager_port '{9}' \ | |||
| && NNI_CODE_DIR={6} && mkdir -p $NNI_SYS_DIR/code && cp -r $NNI_CODE_DIR/. $NNI_SYS_DIR/code && sh $NNI_SYS_DIR/install_nni.sh \ | |||
There was a problem hiding this comment.
How about parameter file? It needs to manual run and verify it at least on remote, and pai.
| @@ -31,6 +31,6 @@ fi`; | |||
|
|
|||
| export const PAI_K8S_TRIAL_COMMAND_FORMAT: string = | |||
| `export NNI_PLATFORM=pai NNI_SYS_DIR={0} NNI_OUTPUT_DIR={1} NNI_TRIAL_JOB_ID={2} NNI_EXP_ID={3} NNI_TRIAL_SEQ_ID={4} MULTI_PHASE={5} \ | |||
| && NNI_CODE_DIR={6} && cp -r $NNI_CODE_DIR/. $NNI_SYS_DIR && cd $NNI_SYS_DIR && sh install_nni.sh \ | |||
| && python3 -m nni_trial_tool.trial_keeper --trial_command '{7}' --nnimanager_ip '{8}' --nnimanager_port '{9}' \ | |||
| && NNI_CODE_DIR={6} && mkdir -p $NNI_SYS_DIR/code && cp -r $NNI_CODE_DIR/. $NNI_SYS_DIR/code && sh $NNI_SYS_DIR/install_nni.sh \ | |||
There was a problem hiding this comment.
never mind, I had a check. It looks good, if test cases doesn't timeout.
SparkSnail
force-pushed
the
dev-fix-v1.6-shinyang
branch
from
133b480 to
25b0d43
Compare
chicm-ms
approved these changes
May 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codefolder to store codeDir for trials in non-local platforms to avoidrun.shconflict