Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Escape environment variable PATH for Windows scripts #3898

Merged
merged 4 commits into from
Aug 20, 2021

Conversation

liuzhe-lz
Copy link
Contributor

I once tried to fix all similar problems together. But it looks too dangerous.

@liuzhe-lz liuzhe-lz requested review from J-shang and acured July 2, 2021 11:16
@J-shang
Copy link
Contributor

J-shang commented Jul 5, 2021

seems we need test this in pipeline

@liuzhe-lz
Copy link
Contributor Author

seems we need test this in pipeline

I found UT is completely broken. Testing exit experiment stops the process and most test cases are not run…
I need to fix it before adding testcase.

@liuzhe-lz liuzhe-lz closed this Jul 7, 2021
@liuzhe-lz liuzhe-lz deleted the escape branch July 7, 2021 07:30
@liuzhe-lz liuzhe-lz restored the escape branch July 7, 2021 07:30
@QuanluZhang QuanluZhang reopened this Aug 3, 2021
@QuanluZhang QuanluZhang requested a review from SparkSnail August 3, 2021 09:08
@QuanluZhang QuanluZhang merged commit c0385c5 into microsoft:master Aug 20, 2021
@liuzhe-lz liuzhe-lz deleted the escape branch October 12, 2021 04:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants