This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Support frameworkcontroller reuse mode #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master
merge master
merge master
merge master
merge master
merge master
merge master
Chinese translation (microsoft#2458)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
78 tasks
liuzhe-lz
reviewed
Sep 13, 2021
| name: 'frameworkbarrier-volume', | ||
| mountPath: '/mnt/frameworkbarrier' | ||
| }] | ||
| }]; |
There was a problem hiding this comment.
These configs look redundant. Would be nice to save repetitive parts into variables and put them in separate place.
liuzhe-lz
approved these changes
Sep 13, 2021
J-shang
reviewed
Sep 15, 2021
| return Promise.resolve(frameworkcontrollerJobConfig); | ||
| } | ||
|
|
||
| private generateContainerPort(taskRoles: FrameworkControllerTrialConfigTemplate[]): void { |
There was a problem hiding this comment.
The indentation after this line looks wrong.
merge master
|
Please fix the conflicts. |
fixed. |
J-shang
approved these changes
Oct 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.