This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
jupyter_ext_dev: pull request for jupyter extension 2.x and 3.x recap… #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cruiseliu
reviewed
Sep 10, 2021
cruiseliu
reviewed
Sep 10, 2021
setup.py
Outdated
| @@ -58,13 +62,25 @@ | |||
| import shutil | |||
| import sys | |||
|
|
|||
| import jupyterlab | |||
There was a problem hiding this comment.
Please add try-catch for this import. The script should not crash when building machine has not installed jupyter.
And I personally suggest put this and jupyter_lab_version = ... into a function get_jupyter_lab_version().
There was a problem hiding this comment.
changed, In this way, the building machine without jupyterlab installed will report error and the package related jupyter lab extension will not built, but continue to build other package
cruiseliu
reviewed
Sep 10, 2021
setup_ts.py
Outdated
| @@ -22,10 +22,11 @@ | |||
| import traceback | |||
| from zipfile import ZipFile | |||
|
|
|||
| import jupyterlab | |||
ultmaster
reviewed
Sep 10, 2021
setup_ts.py
Outdated
| if Path('ts/jupyter_extension/dist').exists(): | ||
| if jupyter_lab_version == '2': | ||
| _symlink('ts/jupyter_extension/build', 'nni_node/jupyter-extension') | ||
| _symlink(sys.exec_prefix+'/share/jupyter/lab/extensions', 'nni_node/jupyter-extension/extensions') |
There was a problem hiding this comment.
Using + to glue two paths is not recommended.
|
|
||
| def restore_package(): | ||
| if jupyter_lab_version == '2': | ||
| package_json = json.load(open('ts/jupyter_extension/.package_default.json')) |
There was a problem hiding this comment.
Delete .package_default.json or put it into gitignore.
Johnsonms
force-pushed
the
jupyter_ext_dev
branch
from
e76e72c to
6f264a2
Compare
ultmaster
approved these changes
Sep 13, 2021
liuzhe-lz
reviewed
Sep 13, 2021
setup.py
Outdated
| if jupyter_lab_version.split('.')[0] != environ_version.split('.')[0]: | ||
| sys.exit(f'ERROR: To build a jupyter lab extension, run "JUPYTER_LAB_VERSION={jupyter_lab_version}", current: {environ_version} ') | ||
| elif jupyter_lab_version.split('.')[0] != '3': | ||
| sys.exit(f'ERROR: To build a jupyter lab extension, run "JUPYTER_LAB_VERSION={jupyter_lab_version}" first for nondefault version(3.x)') |
Johnsonms
force-pushed
the
jupyter_ext_dev
branch
from
6f264a2 to
1e42cf5
Compare
liuzhe-lz
approved these changes
Sep 15, 2021
78 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… #4141
recapped: https://github.com/microsoft/nni/pull/4141/commits