This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Support 'op_partial_names' in config_list #4184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
J-shang
reviewed
Sep 15, 2021
| } | ||
|
|
||
| INTERNAL_SCHEMA = { | ||
| 'total_sparsity': And(float, lambda n: 0 <= n < 1), | ||
| SchemaOptional('max_sparsity_per_layer'): {str: float}, | ||
| SchemaOptional('op_types'): [str], | ||
| SchemaOptional('op_names'): [str] | ||
| SchemaOptional('op_names'): [str], | ||
| SchemaOptional('op_partial_names'): [str] |
There was a problem hiding this comment.
op_partial_names should not in INTERNAL_SCHEMA
There was a problem hiding this comment.
OK, I got it. And next I will add something in need in 'config_validation.py' as well.
Fiascolsy
changed the title
J-shang
reviewed
Sep 22, 2021
| raise SchemaError('At least one of the followings must be specified: op_types, op_names or op_partial_names.') | ||
|
|
||
| if 'op_partial_names' in data: | ||
| if 'op_names' in data: |
J-shang
reviewed
Sep 23, 2021
| config['op_names'].extend(op_names) | ||
| config['op_names'] = list(set(config['op_names'])) | ||
| else: | ||
| config['op_names'] = config.pop('op_partial_names') |
There was a problem hiding this comment.
why config['op_names'] = config.pop('op_partial_names')? seems this config['op_names'] is never used.
There was a problem hiding this comment.
some legacy logic parts have crushed and I optimized this jut now : (
J-shang
approved these changes
Sep 27, 2021
acured
approved these changes
Sep 27, 2021
78 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You now could use 'op_partial_names' instead of 'op_names' in config_list