Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Dev fix aml #4197

Merged
merged 67 commits into from
Sep 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
dcd2ffd
Merge pull request #251 from microsoft/master
SparkSnail May 29, 2020
3b8b6fb
Merge pull request #252 from microsoft/master
SparkSnail Jun 7, 2020
916e444
Merge pull request #253 from microsoft/master
SparkSnail Jun 15, 2020
caeffb8
Merge pull request #254 from microsoft/master
SparkSnail Jun 17, 2020
57c300e
Merge pull request #255 from microsoft/master
SparkSnail Jun 28, 2020
65660e6
Merge pull request #257 from microsoft/master
SparkSnail Jun 30, 2020
9376d6a
Merge pull request #258 from microsoft/master
SparkSnail Jul 1, 2020
5fef3cf
Merge pull request #259 from microsoft/master
SparkSnail Jul 3, 2020
5544ae8
Merge pull request #261 from microsoft/master
SparkSnail Jul 10, 2020
f9fdfee
Merge pull request #262 from microsoft/master
SparkSnail Jul 16, 2020
c5e26ef
add trial job detail link
SparkSnail Jul 19, 2020
10a04ba
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Jul 23, 2020
aa64fe6
Merge pull request #263 from microsoft/master
SparkSnail Jul 27, 2020
4ed907f
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Jul 27, 2020
c6a5f8c
Merge pull request #264 from microsoft/master
SparkSnail Jul 31, 2020
68abe2f
Merge pull request #265 from microsoft/master
SparkSnail Aug 4, 2020
c2b50d2
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Aug 6, 2020
14e9619
Merge pull request #266 from microsoft/master
SparkSnail Aug 13, 2020
f69e206
Merge pull request #267 from microsoft/master
SparkSnail Aug 13, 2020
a5bb753
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Aug 21, 2020
12ef0aa
Merge pull request #270 from microsoft/master
SparkSnail Sep 10, 2020
7600a0f
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Sep 10, 2020
ddcf229
Merge pull request #271 from microsoft/master
SparkSnail Sep 15, 2020
bd327d4
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Sep 15, 2020
c4f6e66
Merge pull request #272 from microsoft/master
SparkSnail Sep 21, 2020
da2d1c4
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Sep 21, 2020
88f8c1b
Merge pull request #273 from microsoft/master
SparkSnail Sep 22, 2020
b59d0e2
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Sep 22, 2020
7eb15f8
Merge pull request #274 from microsoft/master
SparkSnail Oct 27, 2020
f73367f
Merge pull request #275 from microsoft/master
SparkSnail Nov 16, 2020
765bc33
Merge pull request #276 from microsoft/master
SparkSnail Nov 29, 2020
cff51cc
Merge pull request #277 from microsoft/master
SparkSnail Dec 2, 2020
4232fea
Merge pull request #278 from microsoft/master
SparkSnail Dec 8, 2020
cb9efcc
Merge pull request #279 from microsoft/master
SparkSnail Dec 11, 2020
ee71f16
Merge pull request #280 from microsoft/master
SparkSnail Dec 14, 2020
c3921ed
Merge pull request #281 from microsoft/master
SparkSnail Dec 24, 2020
2acbee3
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Dec 29, 2020
561f1ad
Merge pull request #284 from microsoft/master
SparkSnail Jan 22, 2021
21afa8c
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Jan 22, 2021
daf028a
Merge pull request #285 from microsoft/master
SparkSnail Feb 5, 2021
49e3f94
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Feb 5, 2021
9a8a4a3
Merge pull request #286 from microsoft/master
SparkSnail Feb 8, 2021
98dbd10
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Feb 18, 2021
22a38dd
Merge pull request #287 from microsoft/master
SparkSnail Feb 23, 2021
645e1a6
Merge pull request #288 from microsoft/master
SparkSnail Feb 24, 2021
f41c25d
Merge pull request #289 from microsoft/master
SparkSnail Feb 25, 2021
4474ed9
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Feb 25, 2021
9fb5ff9
Merge pull request #290 from microsoft/master
SparkSnail Mar 4, 2021
a2af3c7
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Mar 4, 2021
e3fab14
Merge pull request #291 from microsoft/master
SparkSnail Mar 23, 2021
09514e1
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Mar 31, 2021
ad26f40
Merge pull request #292 from microsoft/master
SparkSnail Apr 12, 2021
ad78613
Merge pull request #294 from microsoft/master
SparkSnail Apr 30, 2021
5453841
Merge pull request #295 from microsoft/master
SparkSnail May 7, 2021
09f977e
Merge pull request #296 from microsoft/master
SparkSnail May 19, 2021
fdb2d77
set version check as warning
SparkSnail May 19, 2021
5190f5a
Merge pull request #297 from microsoft/master
SparkSnail May 24, 2021
805e773
Merge pull request #298 from microsoft/master
SparkSnail May 26, 2021
f9dbdb4
Merge pull request #299 from microsoft/master
SparkSnail Jun 23, 2021
437b020
Merge pull request #300 from microsoft/master
SparkSnail Jul 6, 2021
3605174
Merge pull request #301 from microsoft/master
SparkSnail Jul 23, 2021
b329a32
Merge pull request #302 from microsoft/master
SparkSnail Jul 28, 2021
a8ef4a9
Merge pull request #303 from microsoft/master
SparkSnail Aug 23, 2021
7d4f385
Merge branch 'master' of https://github.com/SparkSnail/nni
SparkSnail Sep 6, 2021
f4644fc
Merge pull request #304 from microsoft/master
SparkSnail Sep 18, 2021
bc842de
init
SparkSnail Sep 18, 2021
e8941ae
Merge branch 'master' of https://github.com/SparkSnail/nni into dev-f…
SparkSnail Sep 18, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ts/nni_manager/config/aml/amlUtil.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
run_config.node_count = 1
config = ScriptRunConfig(source_directory=args.script_dir, script=args.script_name, run_config=run_config)
run = experiment.submit(config)
run_id = run.get_details()["runId"]
print(run.get_details()["runId"])
while True:
line = sys.stdin.readline().rstrip()
Expand All @@ -44,7 +45,17 @@
print('tracking_url:' + run.get_portal_url())
elif line == 'stop':
run.cancel()
exit(0)
with open('~/aml_script_result.log', 'a') as out_file:
out_file.write(run_id + " send stop request")
loop_count = 0
status = run.get_status()
while status != 'Canceled':
if loop_count > 5:
print('stop_result:failed')
exit(0)
loop_count += 1
time.sleep(500)
print('stop_result:success')
elif line == 'receive':
print('receive:' + json.dumps(run.get_metrics()))
elif line:
Expand Down
12 changes: 11 additions & 1 deletion ts/nni_manager/training_service/reusable/aml/amlClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,21 @@ export class AMLClient {
return deferred.promise;
}

public stop(): void {
public stop(): Promise<boolean> {
if (this.pythonShellClient === undefined) {
throw Error('python shell client not initialized!');
}
const deferred: Deferred<boolean> = new Deferred<boolean>();
this.pythonShellClient.send('stop');
this.pythonShellClient.on('message', (result: any) => {
const stopResult = this.parseContent('stop_result', result);
if (stopResult === 'success') {
deferred.resolve(true);
} else {
deferred.resolve(false);
}
});
return deferred.promise;
}

public getTrackingUrl(): Promise<string> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,11 @@ export class AMLEnvironmentService extends EnvironmentService {
if (!amlClient) {
throw new Error('AML client not initialized!');
}
amlClient.stop();
const result = await amlClient.stop();
if (result) {
this.log.info(`Stop ${environment.id} success!`);
} else {
this.log.info(`Stop ${environment.id} failed!`);
}
}
}