Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

[Retiarii] fix missed "attributes" in ToDevice pytorch op #4266

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

hzhua
Copy link
Contributor

@hzhua hzhua commented Oct 21, 2021

In #4214, Operation.new(...) added attributes to be used in __init__.
The ToDevice pytorch op is implemented for CGO, which missed the attributes in __init__.

Copy link
Contributor

@JiahangXu JiahangXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing attributes here. By the way maybe the base branch should be set as v2.5.

@QuanluZhang QuanluZhang changed the base branch from master to v2.5 October 22, 2021 02:12
@hzhua hzhua force-pushed the fix-pytorch-todevice branch 2 times, most recently from eae3641 to acb64c5 Compare October 22, 2021 02:24
@ultmaster ultmaster merged commit 7fe57a0 into microsoft:v2.5 Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants