This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related to #801
When use annotation in a file in a sub-directory and import it from the main program, there's a search space key inconsistency between search space generator and NNI sdk. The latter one use
inspect
library to get module name in a wrong way (without importing path)Background
Note that NNI's annotation variable consists of three parts like:
key = '{}/{}/{}'.format(module, name, function_type)
where the first one is the module path of the file that uses annotation, the second one is the annotated variable name given by user, and the third one is the search space type like
choice
oruniform
. Below we only consider the module part of its key.Comparison
For example, if the main program is
main.py
and users use annotation insubpkg_main.py
, their key is:subpkg_main
subpkg.subpkg_main
subpkg.subpkg_main
subpkg.subpkg_main