Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findNodeAtLocation does not handle incomplete property pair #44

Merged
merged 1 commit into from
Dec 30, 2021
Merged

findNodeAtLocation does not handle incomplete property pair #44

merged 1 commit into from
Dec 30, 2021

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Feb 19, 2021

Rather not a big of a deal considering the document is not syntactically valid, but I believe it might be good to handle it gracefully rather than throwing a TypeError.

Base automatically changed from master to main February 26, 2021 15:21
@aeschli
Copy link
Contributor

aeschli commented Feb 26, 2021

Thanks @P0lip !

@aeschli aeschli added this to the March 2021 milestone Feb 26, 2021
@aeschli aeschli merged commit fee184d into microsoft:main Dec 30, 2021
@aeschli aeschli modified the milestones: March 2021, January 2022 Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants