Correct encoding types

Fixes #312
microsoft · Oct 22, 2019 · 9520129 · 9520129
1 parent 74edc71
commit 9520129
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/interfaces.ts b/src/interfaces.ts
@@ -59,7 +59,7 @@ export interface ITerminal {
   /**
    * Set the pty socket encoding.
    */
-  setEncoding(encoding: string): void;
+  setEncoding(encoding: string | null): void;
 
   /**
    * Resume the pty socket.

diff --git a/src/terminal.ts b/src/terminal.ts
@@ -124,7 +124,7 @@ export abstract class Terminal implements ITerminal {
   }
 
   /** See net.Socket.setEncoding */
-  public setEncoding(encoding: string): void {
+  public setEncoding(encoding: string | null): void {
     if ((<any>this._socket)._decoder) {
       delete (<any>this._socket)._decoder;
     }

diff --git a/typings/node-pty.d.ts b/typings/node-pty.d.ts
@@ -50,7 +50,7 @@ declare module 'node-pty' {
      * If unset, incoming data will be delivered as raw bytes (Buffer type).
      * By default 'utf8' is assumed, to unset it explicitly set it to `null`.
      */
-    encoding?: string;
+    encoding?: string | null;
 
     /**
      * Whether to enable flow control handling (false by default). If enabled a message of `flowControlPause`