fix: retrieving process name on macOS #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
Mar 31, 2023
Comment on lines
+680
to
+686
| pty_getproc(int pid) { | ||
| char pname[MAXCOMLEN + 1]; | ||
| if (!proc_name(pid, pname, sizeof(pname))) { | ||
| return NULL; | ||
| } | ||
|
|
||
| return strdup(kp.kp_proc.p_comm); | ||
| return strdup(pname); |
There was a problem hiding this comment.
I think this is similar to tmux's technique, are we going to regress anywhere by doing it this way? I don't understand how it worked before.
There was a problem hiding this comment.
I went based on the implementation of proc_name which is used in much widely across the kernel code https://github.com/apple/darwin-xnu/blob/2ff845c2e033bd0ff64b5b6aa6063a1f8f65aa32/bsd/kern/kern_proc.c#L1029-L1044 and it seems reliable.
Tyriar
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs microsoft/vscode#178693