Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to NAPI #644

Merged
merged 10 commits into from
Jan 26, 2024
Merged

Port to NAPI #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5dbe674
Port to NAPI
kkocdko Dec 5, 2023
e5028c0
Fix help message in pty.cc
kkocdko Dec 6, 2023
c682e8e
Move NAPI deps to devDependencies in package.json
kkocdko Dec 6, 2023
67142f9
Apply most of deepak1556's suggestions
kkocdko Jan 24, 2024
64478d6
Fix winpty
kkocdko Jan 24, 2024
02e27b4
Fix conpty missing CloseHandle
kkocdko Jan 24, 2024
5bc82dd
Use unique_ptr to avoid `goto`s
kkocdko Jan 24, 2024
bf4ac88
Why macos failed?
kkocdko Jan 24, 2024
27254dd
fix: ci and minor cleanups
deepak1556 Jan 26, 2024
8dfeacd
fix build failed on windows
kkocdko Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ jobs:
inputs:
versionSpec: $(node_version)
displayName: 'Install Node.js'
- script: |
python3 -m pip install setuptools
displayName: Install setuptools (macOS)
- script: |
npm i
displayName: 'Install dependencies and build'
Expand All @@ -54,7 +57,7 @@ jobs:

- job: Windows
pool:
vmImage: 'windows-2019'
vmImage: 'windows-latest'
strategy:
matrix:
node_16_x:
Expand Down Expand Up @@ -87,7 +90,7 @@ jobs:
steps:
- task: NodeTool@0
inputs:
versionSpec: '16.x'
versionSpec: '18.x'
displayName: 'Install Node.js'
- script: |
npm i
Expand Down
19 changes: 4 additions & 15 deletions binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{
'target_defaults': {
'dependencies': [
"<!(node -p \"require('node-addon-api').targets\"):node_addon_api_except",
],
'conditions': [
['OS=="win"', {
'msvs_configuration_attributes': {
Expand Down Expand Up @@ -28,9 +31,6 @@
'targets': [
{
'target_name': 'conpty',
'include_dirs' : [
'<!(node -e "require(\'nan\')")'
],
'sources' : [
'src/win/conpty.cc',
'src/win/path_util.cc'
Expand All @@ -41,17 +41,14 @@
},
{
'target_name': 'conpty_console_list',
'include_dirs' : [
'<!(node -e "require(\'nan\')")'
],
'sources' : [
'src/win/conpty_console_list.cc'
],
},
{
'target_name': 'pty',
'include_dirs' : [
'<!(node -e "require(\'nan\')")',
'<!(node -p "require(\'node-addon-api\').include_dir")',
'deps/winpty/src/include',
],
# Disabled due to winpty
Expand All @@ -73,9 +70,6 @@
'targets': [
{
'target_name': 'pty',
'include_dirs' : [
'<!(node -e "require(\'nan\')")'
],
'sources': [
'src/unix/pty.cc',
],
Expand All @@ -91,11 +85,6 @@
'libraries!': [
'-lutil'
]
}],
['OS=="mac"', {
"xcode_settings": {
"MACOSX_DEPLOYMENT_TARGET":"10.7"
}
}]
]
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"prepublishOnly": "npm run build"
},
"dependencies": {
"nan": "^2.17.0"
"node-addon-api": "^7.1.0"
},
"devDependencies": {
"@types/mocha": "^7.0.2",
Expand Down
Loading