Add "types" to package.json #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Huh weird, it works just fine for me, at least the language services in VS Code. I guess the fact that I'm linking to it from a JS file is the reason.
|
|
Looking at your screenshots, the types there aren't the types from type definitions (check And thank you for your library, it's very nice! |
|
Ah yeah, well I just published 0.6.6 with the types 😃 Please give feedback where things are off as you're working through railsware/upterm#1033 as I don't generally need to touch VS Code's integration with node-pty these days. |
|
That's better 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82.