Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Commit

Permalink
chakrashim: reformat to pass cpplint
Browse files Browse the repository at this point in the history 
Reformat all chakrashim code to pass cpplint. Mostly relayout code to
fit into 80 columns. Including some small code refactorings, C-style
cast to static_cast/reinterpret_cast, etc.

Convert all chakrashim code to \n line ending.

Fix a bug in ContextShim::SetAlignedPointerInEmbedderData where it set
the data only when the vector grows.

Fix a bug in IsolateShim where it didn't initialize embeddedData[].
  • Loading branch information
Jianchun Xu committed May 6, 2015
1 parent 7d2b5ba commit d1bf0be
Show file tree
Hide file tree
Showing 51 changed files with 8,418 additions and 8,722 deletions.
252 changes: 126 additions & 126 deletions deps/chakrashim/chakrashim.gyp
View file
Original file line number Diff line number Diff line change
@@ -1,126 +1,126 @@
{
'variables': {
'library_files': [
'lib/chakra_shim.js',
],
},
'targets': [{
'target_name': 'chakrashim',
'type': '<(library)',

'dependencies': [
'chakra_js2c#host',
],

'include_dirs': [
'include',
'<(SHARED_INTERMEDIATE_DIR)'
],
'defines': [
'USE_EDGEMODE_JSRT=1',
],
'conditions': [
[ 'target_arch=="ia32"', { 'defines': [ '__i386__=1' ] } ],
[ 'target_arch=="x64"', { 'defines': [ '__x86_64__=1' ] } ],
[ 'target_arch=="arm"', { 'defines': [ '__arm__=1' ] } ],
],
'msvs_disabled_warnings': [4091],
'direct_dependent_settings': {
'include_dirs': [
'include',
],
'defines': [
'USE_CHAKRA=1',
'USE_EDGEMODE_JSRT=1',
'_WIN32_WINNT=0x0601',
],
'libraries': [
'-lchakrart.lib',
'-lole32.lib',
'-lversion.lib',
],
'conditions': [
[ 'target_arch=="arm"', {
'defines': [ '__arm__=1' ]
}],
],
'msvs_disabled_warnings': [4091],
},
'sources': [
'include/v8.h',
'include/v8-debug.h',
'include/v8-profiler.h',
'src/jsrtcachedpropertyidref.h',
'src/jsrtcontextshim.cc',
'src/jsrtcontextshim.h',
'src/jsrtcrosscontext.cc',
'src/jsrtcrosscontext.h',
'src/jsrtisolateshim.cc',
'src/jsrtisolateshim.h',
'src/jsrtpromise.cc',
'src/jsrtproxyutils.cc',
'src/jsrtproxyutils.h',
'src/jsrtstringutils.cc',
'src/jsrtstringutils.h',
'src/jsrtutils.cc',
'src/jsrtutils.h',
'src/v8array.cc',
'src/v8boolean.cc',
'src/v8booleanobject.cc',
'src/v8chakra.h',
'src/v8context.cc',
'src/v8date.cc',
'src/v8debug.cc',
'src/v8exception.cc',
'src/v8external.cc',
'src/v8function.cc',
'src/v8functiontemplate.cc',
'src/v8global.cc',
'src/v8handlescope.cc',
'src/v8int32.cc',
'src/v8integer.cc',
'src/v8isolate.cc',
'src/v8message.cc',
'src/v8number.cc',
'src/v8numberobject.cc',
'src/v8object.cc',
'src/v8objecttemplate.cc',
'src/v8persistent.cc',
'src/v8returnvalue.cc',
'src/v8script.cc',
'src/v8signature.cc',
'src/v8string.cc',
'src/v8stringobject.cc',
'src/v8template.cc',
'src/v8trycatch.cc',
'src/v8uint32.cc',
'src/v8v8.cc',
'src/v8value.cc',
],
}, # end chakrashim
{
'target_name': 'chakra_js2c',
'type': 'none',
'toolsets': ['host'],
'msvs_disabled_warnings': [4091],
'actions': [
{
'action_name': 'chakra_js2c',
'inputs': [
'<@(library_files)'
],
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/chakra_natives.h',
],
'action': [
'<(python)',
'./../../tools/js2c.py',
'-chakra',
'<@(_outputs)',
'<@(_inputs)',
],
},
],
}, # end chakra_js2c
],
}
{
'variables': {
'library_files': [
'lib/chakra_shim.js',
],
},
'targets': [{
'target_name': 'chakrashim',
'type': '<(library)',

'dependencies': [
'chakra_js2c#host',
],

'include_dirs': [
'include',
'<(SHARED_INTERMEDIATE_DIR)'
],
'defines': [
'USE_EDGEMODE_JSRT=1',
],
'conditions': [
[ 'target_arch=="ia32"', { 'defines': [ '__i386__=1' ] } ],
[ 'target_arch=="x64"', { 'defines': [ '__x86_64__=1' ] } ],
[ 'target_arch=="arm"', { 'defines': [ '__arm__=1' ] } ],
],
'msvs_disabled_warnings': [4091],
'direct_dependent_settings': {
'include_dirs': [
'include',
],
'defines': [
'USE_CHAKRA=1',
'USE_EDGEMODE_JSRT=1',
'_WIN32_WINNT=0x0601',
],
'libraries': [
'-lchakrart.lib',
'-lole32.lib',
'-lversion.lib',
],
'conditions': [
[ 'target_arch=="arm"', {
'defines': [ '__arm__=1' ]
}],
],
'msvs_disabled_warnings': [4091],
},
'sources': [
'include/v8.h',
'include/v8-debug.h',
'include/v8-profiler.h',
'src/jsrtcachedpropertyidref.inc',
'src/jsrtcontextshim.cc',
'src/jsrtcontextshim.h',
'src/jsrtcrosscontext.cc',
'src/jsrtcrosscontext.h',
'src/jsrtisolateshim.cc',
'src/jsrtisolateshim.h',
'src/jsrtpromise.cc',
'src/jsrtproxyutils.cc',
'src/jsrtproxyutils.h',
'src/jsrtstringutils.cc',
'src/jsrtstringutils.h',
'src/jsrtutils.cc',
'src/jsrtutils.h',
'src/v8array.cc',
'src/v8boolean.cc',
'src/v8booleanobject.cc',
'src/v8chakra.h',
'src/v8context.cc',
'src/v8date.cc',
'src/v8debug.cc',
'src/v8exception.cc',
'src/v8external.cc',
'src/v8function.cc',
'src/v8functiontemplate.cc',
'src/v8global.cc',
'src/v8handlescope.cc',
'src/v8int32.cc',
'src/v8integer.cc',
'src/v8isolate.cc',
'src/v8message.cc',
'src/v8number.cc',
'src/v8numberobject.cc',
'src/v8object.cc',
'src/v8objecttemplate.cc',
'src/v8persistent.cc',
'src/v8returnvalue.cc',
'src/v8script.cc',
'src/v8signature.cc',
'src/v8string.cc',
'src/v8stringobject.cc',
'src/v8template.cc',
'src/v8trycatch.cc',
'src/v8uint32.cc',
'src/v8v8.cc',
'src/v8value.cc',
],
}, # end chakrashim
{
'target_name': 'chakra_js2c',
'type': 'none',
'toolsets': ['host'],
'msvs_disabled_warnings': [4091],
'actions': [
{
'action_name': 'chakra_js2c',
'inputs': [
'<@(library_files)'
],
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/chakra_natives.h',
],
'action': [
'<(python)',
'./../../tools/js2c.py',
'-chakra',
'<@(_outputs)',
'<@(_inputs)',
],
},
],
}, # end chakra_js2c
],
}
65 changes: 33 additions & 32 deletions deps/chakrashim/include/v8-debug.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,38 +28,39 @@
#pragma once
#include <v8.h>

namespace v8
{
// NOT IMPLEMENTED
class EXPORT Debug
{
public:
class ClientData
{
};
namespace v8 {

class Message
{
public:
virtual ~Message() {}
virtual Handle<String> GetJSON() const = 0;
virtual Isolate* GetIsolate() const = 0;
};

typedef void (*DebugMessageDispatchHandler)();
typedef void(*MessageHandler)(const Message& message);
// NOT IMPLEMENTED
class EXPORT Debug {
public:
class ClientData {
};

static void DebugBreak(Isolate *isolate = NULL) {}
static void SetDebugMessageDispatchHandler(DebugMessageDispatchHandler handler, bool provide_locker = false) {}
static bool EnableAgent(const char *name = NULL, int port = 0, bool wait_for_connection = false);
static void Dispose();
static void DisableAgent() {}
static bool IsAgentEnabled();
static void ProcessDebugMessages() {}
static Local<Context> GetDebugContext() { return Context::GetCurrent(); }
static void SetMessageHandler(MessageHandler handler) {}
static void SendCommand(Isolate* isolate,
const uint16_t* command, int length,
ClientData* client_data = NULL) {}
class Message {
public:
virtual ~Message() {}
virtual Handle<String> GetJSON() const = 0;
virtual Isolate* GetIsolate() const = 0;
};
}

typedef void (*DebugMessageDispatchHandler)();
typedef void (*MessageHandler)(const Message& message);

static void DebugBreak(Isolate *isolate = NULL) {}
static void SetDebugMessageDispatchHandler(
DebugMessageDispatchHandler handler, bool provide_locker = false) {}
static bool EnableAgent(
const char *name = NULL, int port = 0, bool wait_for_connection = false);
static void Dispose();
static void DisableAgent() {}
static bool IsAgentEnabled();
static void ProcessDebugMessages() {}
static Local<Context> GetDebugContext() { return Context::GetCurrent(); }
static void SetMessageHandler(MessageHandler handler) {}
static void SendCommand(Isolate* isolate,
const uint16_t* command, int length,
ClientData* client_data = NULL) {
}
};

} // namespace v8
Loading

0 comments on commit d1bf0be

Please sign in to comment.