Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add from existing code should ignore any filepaths that include node_modules and bower_components folders by default #430

Closed
mousetraps opened this issue Sep 8, 2015 · 0 comments
Closed

Add from existing code should ignore any filepaths that include node_modules and bower_components folders by default #430

mousetraps opened this issue Sep 8, 2015 · 0 comments
Labels
bug templates
Milestone
March

Comments

@mousetraps
Copy link
Contributor

This includes instances where node_modules is not at the root of the project. Additionally, we should remove the checkbox that gives people the option to shoot themselves in the foot by including node_modules (which we explicitly advise against doing when you try to perform that action on a node_modules folder node)
@mousetraps mousetraps mentioned this issue Sep 8, 2015
Closed
@mousetraps mousetraps modified the milestone: September Sep 24, 2015
@hoanhtien hoanhtien mentioned this issue Sep 29, 2015
Closed
@brandon-arnold brandon-arnold mentioned this issue Oct 6, 2015
Closed
@mousetraps mousetraps modified the milestones: September, October Oct 11, 2015
@mousetraps mousetraps modified the milestones: October, December Dec 11, 2015
@mousetraps mousetraps modified the milestones: December, January Jan 26, 2016
@mousetraps mousetraps modified the milestones: March, On Radar Feb 20, 2016
mousetraps added a commit to mousetraps/nodejstools that referenced this issue Feb 20, 2016
@mousetraps
microsoft#430 Add from existing code should ignore any filepaths that…
b84f5e2 
… include

node_modules and bower_components by default
- Remove 'exclude node_modules' checkbox
- Exclude node_modules subdirectories
- Exclude bower_components subdirectories

close microsoft#495
=================================
Squashed commit of the following:

commit bfbd26df970628204b7863783598d2ce70ad2c4d
Merge: 141c6bf 0a61329
Author: Sara Itani <sitani@microsoft.com>
Date:   Fri Feb 19 17:21:06 2016 -0800

    Merge branch 'AlwaysExcludeNodeModules' of https://github.com/hoanhtien/nodejstools into hoanhtien-AlwaysExcludeNodeModules

commit 0a61329
Author: Tien Nguyen <tihoanh@microsoft.com>
Date:   Fri Oct 16 14:14:14 2015 -0700

    Brace on same line.

commit 1dd9930
Author: Tien Nguyen <tihoanh@microsoft.com>
Date:   Fri Oct 16 14:11:30 2015 -0700

    Add a test case for importing bower_components.

commit f0c29a1
Merge: d5729ab b801b60
Author: Tien Nguyen <tihoanh@microsoft.com>
Date:   Fri Oct 16 13:58:40 2015 -0700

    Merge remote-tracking branch 'microsoft/master' into AlwaysExcludeNodeModules

commit d5729ab
Author: Tien Nguyen <tihoanh@microsoft.com>
Date:   Fri Oct 16 13:57:58 2015 -0700

    Remove binding ExcludeNodeModules.

commit f5651fb
Author: Tien Nguyen <tihoanh@microsoft.com>
Date:   Tue Sep 29 15:13:08 2015 -0700

    Exclude bower_components folders.

commit 963b453
Author: Tien Nguyen <tihoanh@microsoft.com>
Date:   Tue Sep 29 14:06:31 2015 -0700

    Exlude node_modules subfolders.

commit 85ccff4
Author: Tien Nguyen <tihoanh@microsoft.com>
Date:   Mon Sep 28 19:19:33 2015 -0700

    Remove 'exclude node_modules' checkbox.
This was referenced Feb 20, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug templates
Projects
None yet
Milestone
March
Development

Successfully merging a pull request may close this issue.

Always exclude node modules hoanhtien/nodejstools
2 participants
@mousetraps @hoanhtien