Azure template fix #1519
Merged
Azure template fix #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 2, 2017 16:19
The Id is pulled from the vspackage.resx file (and the matching localized files)
paulvanbrenk
force-pushed
the
azureTemplateFix
branch
2 times, most recently
from
a15a99a
to
f4c0667
Compare
paulvanbrenk
force-pushed
the
azureTemplateFix
branch
from
f4c0667
to
37edbc7
Compare
billti
reviewed
Apr 11, 2017
|
|
||
| module.exports = app; | ||
| var server = app.listen(app.get('port'), function () { | ||
| debug('Express server listening on port ' + server.address().port); |
There was a problem hiding this comment.
Did you try running this and seeing if there are errors? I don't see where 'debug' is defined/imported, so I assume this line throws.
There was a problem hiding this comment.
Forgot to comment that out in the template.
comment out debug statement
billti
reviewed
Apr 11, 2017
| <!-- Remote debugging (Azure Website with git deploy): Uncomment NtvsDebugProxy handler below. | ||
| Additionally copy Microsoft.NodejsTools.WebRole to 'bin' from the Remote Debug Proxy folder.--> | ||
| <!--<add name="NtvsDebugProxy" path="ntvs-debug-proxy/$guid2$" verb="*" resourceType="Unspecified" | ||
| type="Microsoft.NodejsTools.Debugger.WebSocketProxy, Microsoft.NodejsTools.WebRole"/>--> |
There was a problem hiding this comment.
So still removing this bit then - not needed?
There was a problem hiding this comment.
Missed in reverting change
billti
reviewed
Apr 11, 2017
| <ZipProject Include="ProjectTemplates\AzureNodejsApp\Web.Debug.config"> | ||
| <SubType>Designer</SubType> | ||
| </ZipProject> | ||
| <ZipProject Include="ProjectTemplates\AzureNodejsApp\Web.config" /> | ||
| <ZipProject Include="ProjectTemplates\AzureNodejsApp\node.cmd" /> | ||
| <ZipProject Include="ProjectTemplates\AzureNodejsApp\iisnode.yml" /> |
There was a problem hiding this comment.
Why are you leaving the iisnode.yml file in some templates, and not others? Is it needed in some?
There was a problem hiding this comment.
removed from the actual projects, put left in the csproj file by accident. Removed now
billti
reviewed
Apr 11, 2017
| @@ -2,8 +2,13 @@ | |||
| "name": "$npmsafeprojectname$", | |||
| "version": "0.0.0", | |||
| "description": "$projectname$", | |||
| "main": "app.js", | |||
| "scripts": { | |||
| "start": "node server" | |||
There was a problem hiding this comment.
Did the main module change from app.js to server.js?
billti
reviewed
Apr 11, 2017
| @@ -2,8 +2,13 @@ | |||
| "name": "$npmsafeprojectname$", | |||
| "version": "0.0.0", | |||
| "description": "$projectname$", | |||
| "main": "app.js", | |||
| "scripts": { | |||
| "start": "node server" | |||
There was a problem hiding this comment.
yep changed from app to server
billti
reviewed
Apr 11, 2017
|
|
||
| module.exports = app; | ||
| var server = app.listen(app.get('port'), function () { | ||
| debug('Express server listening on port ' + server.address().port); |
billti
reviewed
Apr 11, 2017
|
|
||
| module.exports = app; | ||
| var server = app.listen(app.get('port'), function () { | ||
| debug('Express server listening on port ' + server.address().port); |
billti
approved these changes
Apr 11, 2017
uniqueiniquity
pushed a commit
to uniqueiniquity/nodejstools
that referenced
this pull request
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NodeJs templates in VS no longer work on Azure. This cleans up the templates to they work without changes.