Skip to content

Features/dbfs #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .idea/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/inspectionProfiles/profiles_settings.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions .idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions .idea/modules.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions .idea/nutter.iml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/vcs.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions common/resultreports.py
Original file line number Diff line number Diff line change
@@ -32,6 +32,10 @@ def has_data(self):
def write(self):
pass

@abstractmethod
def write_to_dbfs(self, dbfs_path):
pass

def _validate_add_results(self, notebook_path, test_result):
if not isinstance(test_result, TestResults):
raise ValueError('Expected an instance of TestResults')
@@ -85,6 +89,10 @@ def write(self):

return report_name

def write_to_dbfs(self, dbfs_path):
self.to_file(dbfs_path)
return dbfs_path

def to_file(self, path):
file = open(path, 'w')
try:
@@ -137,6 +145,10 @@ def write(self):

return report_name

def write_to_dbfs(self, dbfs_path):
self.to_file(dbfs_path)
return dbfs_path

def to_file(self, path):
file = open(path, 'w')
try:
15 changes: 15 additions & 0 deletions common/testexecresults.py
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
"""

from .apiclientresults import ExecuteNotebookResult, NotebookOutputResult
from .resultreports import JunitXMLReportWriter, TagsReportWriter
from .resultsview import RunCommandResultsView
from .testresult import TestResults

@@ -31,3 +32,17 @@ def get_ExecuteNotebookResult(self, notebook_path, test_results):
'N/A', None, test_results)

return ExecuteNotebookResult('N/A', 'N/A', notebook_result, 'N/A')

def write_junit_xml_report_to_dbfs(self, notebook_path, dbfs_report_path):
junit_xml_report_writer = JunitXMLReportWriter()
junit_xml_report_writer.add_result(notebook_path, self.test_results)
junit_xml_report_writer.write_to_dbfs(dbfs_report_path)

return dbfs_report_path

def write_tags_report_to_dbfs(self, notebook_path, dbfs_report_path):
tags_report_writer = TagsReportWriter()
tags_report_writer.add_result(notebook_path, self.test_results)
tags_report_writer.write_to_dbfs(dbfs_report_path)

return dbfs_report_path