-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
httpclient.c:_RequestCallbackWrite does not handle partial sends. #439
Comments
NOTE: A possible fix is to make the call to _WriteClientHandler conditioned on handler->sendHeader: |
When connecting to office 365 with my domain credentials, the size of the client data exceeds the send buffer size and a partial send occurs. _RequestCallbackWrite calls _WriteClientHeader followed by _WriteClientData. When _RequestCallbackWrite is called a second time, it again calls _WriteClientHeader which returns an error since there is no header data to send.
A possible fix is to update _RequestCallbackWrite to detect the continuation of the client data and not call _WriteClientHeader. Added a (handler->SendHeader) condition appears to solve the problem but may not be the right solution.
This is blocking New-PSSession in PowerShell Core on non-windows systems. See PowerShell/PowerShell#5130
The text was updated successfully, but these errors were encountered: