Fully escape allowlist rules

microsoft · Jan 27, 2023 · 01175a2 · 01175a2
1 parent 6829318
commit 01175a2
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/src/agent/coverage/src/allowlist.rs b/src/agent/coverage/src/allowlist.rs
@@ -167,16 +167,10 @@ impl AllowListLine {
 
 #[allow(clippy::single_char_pattern)]
 fn glob_to_regex(expr: &str) -> Result<Regex> {
-    // Treat `.` as literal, not match-any.
-    //
-    // Use character class syntax to avoid double-escaping.
-    let expr = expr.replace(".", r"[.]");
+    let expr = regex::escape(expr);
 
-    // Don't make users escape Windows path separators.
-    let expr = expr.replace(r"\", r"\\");
-
-    // Translate glob wildcards into quantified regexes.
-    let expr = expr.replace("*", ".*");
+    // Translate escaped glob wildcards into quantified regexes.
+    let expr = expr.replace(r"\*", ".*");
 
     // Anchor to line start and end.
     let expr = format!("^{expr}$");