Migrate from winapi to windows-rs (#3050)

`windows-rs` is the newer, Microsoft-supported version of the API bindings; `winapi` hasn't been updated in some time. This allows us to remove some code, as `windows-rs` includes the `Sym*` functions that we had to previously defined ourselves in `dbghelp`. Rather than port the `jobs` and `com` code I removed it, as it was unused. The `check_hr` and `check_winapi` macros have been replaced by use of `.ok()?` on `BOOL` and `?` on `HRESULT` which now support standard error handling facilities.
microsoft · Aug 8, 2023 · 58447f7 · 58447f7
1 parent 3851ab0
commit 58447f7
Show file tree

Hide file tree

Showing 40 changed files with 694 additions and 1,945 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -1,2 +1,3 @@
-* text=auto
-*.ps1 text=crlf
+*     text=auto
+*.ps1 text eol=crlf
+*.sh  text eol=lf
diff --git a/src/agent/Cargo.lock b/src/agent/Cargo.lock
diff --git a/src/agent/debugger/Cargo.toml b/src/agent/debugger/Cargo.toml
@@ -16,20 +16,6 @@ rand = "0.8"
 serde = { version = "1.0", features = ["derive"] }
 win-util = { path = "../win-util" }
 
-[dependencies.winapi]
-version = "0.3"
-features = [
-    "dbghelp",
-    "debugapi",
-    "handleapi",
-    "impl-default",
-    "memoryapi",
-    "namedpipeapi",
-    "processthreadsapi",
-    "securitybaseapi",
-    "shellapi",
-    "synchapi",
-    "werapi",
-    "winbase",
-    "winerror",
-]
+[dependencies.windows]
+version = "0.48"
+
diff --git a/src/agent/debugger/src/breakpoint.rs b/src/agent/debugger/src/breakpoint.rs
@@ -8,7 +8,7 @@ use std::{
 
 use anyhow::Result;
 use win_util::process;
-use winapi::um::winnt::HANDLE;
+use windows::Win32::Foundation::HANDLE;
 
 use crate::debugger::{BreakpointId, BreakpointType};