properly add entries to the cache

microsoft · Sep 29, 2022 · 7c64453 · 7c64453
1 parent 648186c
commit 7c64453
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/ApiService/ApiService/onefuzzlib/VmssOperations.cs b/src/ApiService/ApiService/onefuzzlib/VmssOperations.cs
@@ -193,19 +193,21 @@ public async Async.Task<IDictionary<Guid, string>> ListInstanceIds(Guid name) {
     private record InstanceIdKey(Guid Scaleset, Guid VmId);
     private Task<string> GetInstanceIdForVmId(Guid scaleset, Guid vmId)
         => _cache.GetOrCreateAsync(new InstanceIdKey(scaleset, vmId), async entry => {
-            entry.AbsoluteExpirationRelativeToNow = TimeSpan.FromMinutes(10);
             var scalesetResource = GetVmssResource(scaleset);
             var vmIdString = vmId.ToString();
             await foreach (var vm in scalesetResource.GetVirtualMachineScaleSetVms().AsAsyncEnumerable()) {
                 var response = await vm.GetAsync();
                 var instanceId = response.Value.Data.InstanceId;
                 if (response.Value.Data.VmId == vmIdString) {
                     // we found the VM we are looking for
+                    entry.AbsoluteExpirationRelativeToNow = TimeSpan.FromMinutes(10);
                     return instanceId;
                 } else {
                     // if we find any other VMs, put them in the cache
                     if (Guid.TryParse(response.Value.Data.VmId, out var vmId)) {
-                        _ = _cache.CreateEntry(new InstanceIdKey(scaleset, vmId)).SetValue(instanceId);
+                        using var e = _cache.CreateEntry(new InstanceIdKey(scaleset, vmId));
+                        _ = e.SetValue(instanceId);
+                        e.AbsoluteExpirationRelativeToNow = TimeSpan.FromMinutes(10);
                     }
                 }
             }