Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

github issue notification in templates not working #981

Closed
bmc-msft opened this issue Jun 10, 2021 · 0 comments · Fixed by #982 or #985
Closed

github issue notification in templates not working #981

bmc-msft opened this issue Jun 10, 2021 · 0 comments · Fixed by #982 or #985
Labels
bug Something isn't working

Comments

@bmc-msft
Copy link
Contributor

bmc-msft commented Jun 10, 2021

There is an issue using the GitHub notification integration from job templates.

This command:

onefuzz template libfuzzer A B C linux --notification_config @~/onefuzz/contrib/onefuzz-job-github-actions/github-issues.json

results in this error:

ERROR:cli:command failed: request did not succeed: HTTP 400 - {"code": 450, "errors": ["config.base_url: field required", "config.auth_token: field required", "config.project: field required", "config.type: field required", "config.unique_fields: field required", "config.ado_fields: field required", "config.on_duplicate.increment: field required", "config.on_duplicate.set_state: field required", "config.on_duplicate.ado_fields: field required", "config.url: field required", "config.auth.url: field required"]}

Note, these are the configuration errors for Azure Devops notifications, not GitHub. Both should be usable here.

AB#43103029

@bmc-msft bmc-msft added the bug Something isn't working label Jun 10, 2021
@ghost ghost added the Needs: triage label Jun 10, 2021
@bmc-msft bmc-msft linked a pull request Jun 10, 2021 that will close this issue
@bmc-msft bmc-msft linked a pull request Jun 11, 2021 that will close this issue
@ghost ghost closed this as completed in #982 Jun 11, 2021
ghost pushed a commit that referenced this issue Jun 12, 2021
This normalizes the SecretData serialization from the client to address #981.

When serializing objects sent to the service with secrets, we would turn it into a SecretData

We use SecretData to convert this:
`{"auth": {"user": "A", "personal_access_token": "B"}}`
to this:
`"auth": { "secret": { "url": "https://KEYVAULT-URL" }}`

Currently, in the case we have a SecretData we've not yet saved, the serialized form looks like this:
`{"auth": { "secret": {"user": "A", "personal_access_token": "B"}}}`

This PR simplifies the client side serialization to this:
`{"auth": {"user": "A", "personal_access_token": "B"}}`
@ghost ghost locked as resolved and limited conversation to collaborators Jul 11, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
2 participants