This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
remove nodes from db upon reimage #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmc-msft
changed the title
ranweiler
reviewed
Jun 22, 2021
There was a problem hiding this comment.
IIUC, this moves us from a more explicit model (where we flag reimage-queued nodes) to an implicit one, where we rely on some expected future behavior to cause the right end result. I find the correctness of this very hard to reason about.
Is there another variation we could use? Would it be better to add more state to reimage_request, e.g. some form of counter, or a new state like reimage_finishing?
ranweiler
approved these changes
Jun 22, 2021
|
Hello @bmc-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag
Node.reimage_queuedis intended to stop nodes from reimaging repeatedly.In #970, in order to work around Azure API failures, this flag was cycled if the node was already set to cleanup. Unfortunately, reimaging can sometimes take a significant amount of time, causing this change to get nodes multiple times.
Instead of using
reimage_queuedas a flag, this PR deletes the node from the storage table upon reimage. When the node registers OR the next time throughScaleset.cleanup_nodes, the Node will be recreated automatically, whichever comes first.