This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Enable autoscaling based on worksets #1056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't used at the moment, but pulled forwards from the autoscale PR. The functionality replicates the scaleset based shrink-queue, but at the context of pools.
chkeita
reviewed
Jul 14, 2021
chkeita
approved these changes
Jul 14, 2021
|
Investigating autoscaling using VMSS tied to storage queues. For now, this will be closed and can be reopened if that doesn't worked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on past PRs for autoscaling, as well as #1046, #1047, #1049, and #1050.
For scaling down, this uses the existing
ShrinkQueuemechanism, which has been used to scale down scalesets.For scaling up, this orders scalesets by scaleset_id, then increases the size to each scalesets max size. This should hopefully reduce fragmentation. The actual increase happens through the existing resize.
Note: AutoScaleConfig.scaleset_size from the original autoscaling component is no longer used. it's left here for backwards compat with existing CLIs.