Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

handle libfuzzer targets failing without dropping crash files #108

Merged
merged 3 commits into from
Oct 7, 2020
Merged

handle libfuzzer targets failing without dropping crash files #108

merged 3 commits into from
Oct 7, 2020

Conversation

bmc-msft
Copy link
Contributor

@bmc-msft bmc-msft commented Oct 6, 2020

Summary of the Pull Request

Handle libfuzzer targets exiting with an error without recording crash files

PR Checklist

  • Applies to work item: handle libfuzzer targets crashing without dropping an a crashing input #57
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

  • Moves src/process.rs from onefuzz-supervisor to onefuzz
  • Keeps a copy of stderr in case the fuzzer crashes without dropping crash file
  • Adds onefuzz-agent debug libfuzzer_fuzz debug subcommand to test libfuzzer targets locally

Validation Steps Performed

  • Deploy a regular libfuzzer task and note it detects crashes as appropriate
  • Deploy a target that does raise(SIGKILL); and note that we mark the task is failed

@bmc-msft bmc-msft linked an issue Oct 6, 2020 that may be closed by this pull request
@bmc-msft bmc-msft merged commit 4071794 into microsoft:main Oct 7, 2020
@bmc-msft bmc-msft deleted the handle-libfuzzer-failure branch October 7, 2020 13:06
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle libfuzzer targets crashing without dropping an a crashing input
3 participants