Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Replace notifications by default #1084

Merged
merged 6 commits into from
Jul 20, 2021
Merged

Replace notifications by default #1084

merged 6 commits into from
Jul 20, 2021

Conversation

bmc-msft
Copy link
Contributor

This PR adds two features:

  1. On creating notifications for containers that already have notification configs, this replaces the existing notifications by default
  2. Instead of returning all containers, then iterating over all containers, enable searching the notifications by container name

chkeita
chkeita reviewed Jul 19, 2021
View reviewed changes
src/cli/onefuzz/api.py Outdated Show resolved Hide resolved
bmc-msft
bmc-msft commented Jul 20, 2021
View reviewed changes
src/cli/onefuzz/api.py Outdated Show resolved Hide resolved
@bmc-msft bmc-msft requested a review from chkeita July 20, 2021 21:11
@bmc-msft bmc-msft merged commit 0652721 into microsoft:main Jul 20, 2021
@bmc-msft bmc-msft deleted the replace-notifications-by-default branch July 20, 2021 22:39
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chkeita chkeita chkeita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmc-msft @chkeita @demoray