This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
enable the supervisor to handle longer service outages #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkeita
approved these changes
Jul 21, 2021
…hile-running-tasks
ranweiler
reviewed
Jul 21, 2021
Co-authored-by: Joe Ranweiler <joe@lemma.co>
…hile-running-tasks
…g-tasks' of github.com:bmc-msft/onefuzz into enable-agent-to-handle-long-service-outage-while-running-tasks
…hile-running-tasks
ranweiler
approved these changes
Jul 21, 2021
…g-tasks' of github.com:bmc-msft/onefuzz into enable-agent-to-handle-long-service-outage-while-running-tasks
ranweiler
approved these changes
Jul 21, 2021
bmc-msft
deleted the
enable-agent-to-handle-long-service-outage-while-running-tasks
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current API retry code at the agent level will fail if the service is down for more than 25 seconds. In the case of longer outages such as those seen in #1095, it would be useful if the supervisor was more resilient while running existing tasks.
This PR enables the supervisor's
poll commandsandclaim commandsinteractions with the service to be fallible at the transport layer (https), but not at the content layer (json).