This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
retry when preauthorized application are invalid #1175
Merged
+35
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmc-msft
reviewed
Aug 24, 2021
Co-authored-by: bmc-msft <41130664+bmc-msft@users.noreply.github.com>
ranweiler
approved these changes
Aug 24, 2021
|
@chkeita, could you please note how to manually test this? To confirm, did we test with:
|
Updated the summary |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Handles the case when an application registration is deleted but is still referenced as a preauthorized application in the instance registration.
This adds a logic to remove any invalid application id form the request to authorize applications.
closes #1171
How to test:
1 - create multiple registration
python registration.py create_cli_registration <instance_namm> subscription_id --registration_name <name>2- delete some of the application registration in the azure portal
3- create another registration with step 1
Tested
[x] 0 deleted app
[x]1 deleted app
Could not test with >1 app because i had redeployed my environment and the issue does not repro in my new instance application registration.