This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 198
Custom Extension Instance Configuration #1184
Merged
bmc-msft
merged 39 commits into
microsoft:main
from
nharper285:user/noharper/extension-instance-config
Sep 24, 2021
Merged
Custom Extension Instance Configuration #1184
bmc-msft
merged 39 commits into
microsoft:main
from
nharper285:user/noharper/extension-instance-config
Sep 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmc-msft
reviewed
Aug 26, 2021
bmc-msft
reviewed
Aug 26, 2021
bmc-msft
reviewed
Aug 26, 2021
bmc-msft
reviewed
Aug 26, 2021
bmc-msft
reviewed
Aug 26, 2021
bmc-msft
reviewed
Aug 26, 2021
bmc-msft
reviewed
Aug 26, 2021
bmc-msft
reviewed
Aug 26, 2021
bmc-msft
reviewed
Aug 26, 2021
bmc-msft
reviewed
Aug 27, 2021
bmc-msft
reviewed
Aug 27, 2021
bmc-msft
reviewed
Aug 27, 2021
bmc-msft
reviewed
Aug 27, 2021
Can you confirm that the azsec extension is working correctly? |
I have an experiment running now that will confirm this! |
bmc-msft
reviewed
Aug 27, 2021
bmc-msft
reviewed
Aug 27, 2021
bmc-msft
reviewed
Aug 27, 2021
…hub.com/nharper285/onefuzz into user/noharper/extension-instance-config
@bmc-msft, I can finally confirm that changes work :) Data took longer than expected to propagate to s360. |
…hub.com/nharper285/onefuzz into user/noharper/extension-instance-config
This reverts commit 7af1287.
This reverts commit dba171d.
@bmc-msft, I've reverted the changes. |
bmc-msft
approved these changes
Sep 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
This is the final 'draft' of the Custom Extension work that we have undertaken to enable Microsoft Security Monitoring extensions for OneFuzz virtual assets. The Azure Keyvault extension has also been enabled, as it is a pre-req for the security monitoring extensions. This work leverages the InstanceConfiguration infrastructure developed by MSR.
PR Checklist
CLA signed. If not, go over here and sign the CLI.Tests added/passedRequires documentation to be updatedInfo on Pull Request
What does this include?
These pull request includes changes to:
Validation Steps Performed
How does someone test & validate?
I have fully tested this functionality by deploying a local build, configuring a valid InstanceConfig, and deploying VMSS. I have confirmed that azure monitor events show up in geneva.