This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 198
Move to using api://
for AAD Application "identifier uris"
#1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkeita
reviewed
Sep 14, 2021
chkeita
reviewed
Sep 14, 2021
stishkin
force-pushed
the
stas/test
branch
6 times, most recently
from
September 15, 2021 17:31
d033c75
to
e65a7e8
Compare
chkeita
reviewed
Sep 15, 2021
chkeita
reviewed
Sep 15, 2021
stishkin
force-pushed
the
stas/test
branch
2 times, most recently
from
September 15, 2021 19:33
c71e8ca
to
cfb306d
Compare
chkeita
reviewed
Sep 15, 2021
stishkin
force-pushed
the
stas/test
branch
2 times, most recently
from
September 15, 2021 20:08
03d9eb9
to
afaba3c
Compare
chkeita
reviewed
Sep 15, 2021
stishkin
force-pushed
the
stas/test
branch
2 times, most recently
from
September 15, 2021 21:29
5cc75b1
to
297cd75
Compare
Can this PR have a different name than |
stishkin
changed the title
test
App registration fails when deploying new instance of OneFuzz
Sep 15, 2021
Received an error while trying to deploy to multitenant:
I used the following deploy command: |
chkeita
reviewed
Sep 15, 2021
chkeita
reviewed
Sep 15, 2021
Validation in progress
|
I tested and can confirm we have a running job in multi-tenant instance. |
bmc-msft
changed the title
App registration fails when deploying new instance of OneFuzz
Move to using Sep 17, 2021
api://
for AAD Application "identifier uris"
chkeita
approved these changes
Sep 17, 2021
ghost
locked as resolved and limited conversation to collaborators
Nov 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
PR Checklist
Info on Pull Request
What does this include?
Updating Application ID URI in AppRegistration to a URI accepted by Azure. Moving URI from
https://
toapi://
.Updating all the code that requires Application ID URI to use a new format.
Validation Steps Performed
How does someone test & validate?
Run integration test, more tests will be done by @chkeita