Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

use installed azcopy if the packaged azcopy versions are not compatable #126

Merged
merged 1 commit into from
Oct 9, 2020
Merged

use installed azcopy if the packaged azcopy versions are not compatable #126

merged 1 commit into from
Oct 9, 2020

Conversation

bmc-msft
Copy link
Contributor

@bmc-msft bmc-msft commented Oct 9, 2020

Summary of the Pull Request

This checks if the azcopy we provide are compatible with the host used for deployment and otherwise makes use of the user-installed azcopy.

This enables deployment on non-x86_64 Linux/Windows platforms (such as OSX)

PR Checklist

  • Applies to work item: OSError: [Errno 8] Exec format error: 'tools/linux/azcopy' #120
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

  1. The deployment scripts still prefer the built-in azcopy, but will use the system provided azcopy if our built-in versions are incompatible.
  2. Addresses lint issues in the deploy code
  3. Adds missing copyright to code written by MSFT

Validation Steps Performed

Run deployment from a linux/x86_64 platform and an OSX platform. Both should succeed.

@bmc-msft bmc-msft merged commit f43c44e into microsoft:main Oct 9, 2020
@bmc-msft bmc-msft deleted the optionally-use-builtin-azcopy branch October 9, 2020 16:39
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants