Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

validate that subnet nsg is set before getting it's ID #1409

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

stishkin
Copy link
Contributor

validate that subnet nsg is set before getting it's ID

@stishkin stishkin requested a review from nharper285 October 28, 2021 21:09
Copy link
Contributor

@nharper285 nharper285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and looks good!!

@stishkin stishkin merged commit b8b4afe into microsoft:feature/proxy-nsg Oct 28, 2021
@stishkin stishkin deleted the validate-subnet-nsg branch October 28, 2021 21:43
stishkin added a commit to stishkin/onefuzz that referenced this pull request Nov 2, 2021
stishkin added a commit that referenced this pull request Nov 4, 2021
Co-authored-by: stas <statis@microsoft.com>
stishkin added a commit that referenced this pull request Nov 4, 2021
* associate subnets with NSG

change NSG rule protocol to ANY

* subnet wait

* Improve NSG update logic

validate that subnet nsg is set before getting it's id (#1409)

Co-authored-by: stas <statis@microsoft.com>
stishkin added a commit that referenced this pull request Nov 5, 2021
* associate subnets with NSG

change NSG rule protocol to ANY

* subnet wait

* Improve NSG update logic

validate that subnet nsg is set before getting it's id (#1409)

Co-authored-by: stas <statis@microsoft.com>
@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants