This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
SP Guest Account Access locked down by default and deploying user added as admin. #1425
Merged
nharper285
merged 30 commits into
microsoft:main
from
nharper285:user/noharper/guest-access-sp
Nov 5, 2021
Merged
SP Guest Account Access locked down by default and deploying user added as admin. #1425
nharper285
merged 30 commits into
microsoft:main
from
nharper285:user/noharper/guest-access-sp
Nov 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkeita
reviewed
Nov 2, 2021
chkeita
reviewed
Nov 2, 2021
chkeita
reviewed
Nov 4, 2021
chkeita
reviewed
Nov 4, 2021
chkeita
reviewed
Nov 4, 2021
…arper285/onefuzz into user/noharper/guest-access-sp
chkeita
reviewed
Nov 4, 2021
Co-authored-by: Cheick Keita <kcheick@gmail.com>
chkeita
reviewed
Nov 4, 2021
chkeita
approved these changes
Nov 4, 2021
ghost
locked as resolved and limited conversation to collaborators
Dec 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
For service principals created by the OneFuzz platform during deployment, we default to setting "User Assignment Required" to
false
. In the deployment script, this is controlled by the parameterapp_role_assignment_required
.Change: set
app_role_assignment_required
totrue
by default, and add the user who deploys a given instance of OneFuzz as a pre-authorized user. The owner/deployer could then add additional users, as necessary. We could enable this functionality by including a deployment parameter that takes in an authenticated group, as chosen by the deploying user. Theoretically, this could just use the 'admins' parameter at deployment time to add users.PR Checklist
Info on Pull Request
What does this include?
deploy.py:
app_role_assignment_required
set to true and includes new call to add_user()registration.py: add_user function that takes in principal id(s) and add them to the SP.
Validation Steps Performed
How does someone test & validate?
app_role_assignment_required
set to true during deployment.