This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Don't cache debuginfo sessions #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2021
stishkin
approved these changes
Dec 17, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the currently-unused
DebugInfo.sessionfield to easeasyncusage.The removed field has type
ObjectDebugSession, which is notSend. This is problematic in anasynccontext. We could work around it, and probably even craft aSendwrapper type (which would require judicious use ofunsafe). However, in our coverage task, we don't actually use debug sessions at all. In the future, we can still easily get them on-demand fromObjectvalues (which we do cache). So, just remove the cached session field until we actually need it.