Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Remove in-agent tracking of child process perf stats #1608

Merged
merged 4 commits into from
Jan 25, 2022

Conversation

ranweiler
Copy link
Member

@ranweiler ranweiler commented Jan 24, 2022

  • Remove the process_stats custom event
  • Stop "manually" recording libfuzzer child process resource usage in the onefuzz-agent process
  • Remove the onefuzz::system module and our dependency on sysinfo

We can use Azure Monitor perf counters to get the same information, in a more robust, queryable, and less intrusive way. Using sysinfo in our long-lived parent process setting is prone to handle leaks on Windows, which caused task-failing OOM scenarios with certain fuzzer targets and target behaviors.

Due to the removal of the custom event, this is a breaking change.

Fixes #1064.

@ranweiler ranweiler merged commit 2ad37bd into microsoft:main Jan 25, 2022
@ranweiler ranweiler deleted the remove-proc-stats branch January 25, 2022 23:06
@ghost ghost locked as resolved and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows nodes sometimes go OOM on libfuzzer tasks
4 participants